I'm having a similar issue with DatabasePager::RequestQueue::takeFirst()
(osg trunk, Debug build, windows XP VS2005). I'm getting some assertion
errors at _requestList.sort ("sequence not ordered"). Even after adding
the updateBlock().
I'm pretty new to this code section, so I'm probably off base here: Is
it possible that the state of the databaseRequest objects within the
list are being updated (from other threads) during the sort?
IE. If the _timestampLastRequest or _priorityLastRequest are changing
during the sort, the sort could become unstable.
_______________________________________________
Jim Lynch
-----Original Message-----
On Tue, May 27, 2008 at 12:08 PM, Tim Moore <timoore at redhat.com>
wrote:
>
> Indeed. I've made the necessary changes to FlightGear, and it seems to
> be working fine.
Except for being a cpu hog.
Apparently, the pager thread is not blocked properly and continuously
spins. The fact that the queue is empty is confirmed by the debug
messages printed after the block call:
HANDLE_NON_HTTP 0: _pager->_requestList.size()= 0 to delete = 0
I have been trying to find the place where the blocking is
re-established when the queue goes empty, but could not find it. So I
added an updateBlock() call at the end of
DatabasePager::RequestQueue::takeFirst that seems to fix the issue.
Could have added the call within the if-block, but this has the
additional benefit of stopping runaway loops should somehow the pager
thread get woken up without work to do.
Index: DatabasePager.cpp
===================================================================
--- DatabasePager.cpp (revision 8398)
+++ DatabasePager.cpp (working copy)
@@ -273,6 +273,7 @@
databaseRequest = _requestList.front();
_requestList.erase(_requestList.begin());
}
+ updateBlock();
}
I am not sure if I need an osg-submissions mail for this?
--
Cheers,
Csaba/Jester.org/listinfo.cgi/osg-users-openscenegraph.org
The information contained in this communication may be CONFIDENTIAL and is
intended only for the use of the recipient(s) named above. If you are not the
intended recipient, you are hereby notified that any dissemination,
distribution, or copying of this communication, or any of its contents, is
strictly prohibited. If you have received this communication in error, please
notify the sender and delete/destroy the original message and any copy of it
from your computer or paper files.
_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
