On Tue, Aug 26, 2008 at 6:27 AM, Mattias Helsing <[EMAIL PROTECTED]>wrote:
> > A less risky fix to elliminate the warning would be to append ".lib" to > line > > 36 and collapse that conditional block. > > This is what I have done and attached. It works on my available > configurations, removes a few redundant lines and won't require that > cmake_policy setting in the top-level CMakeLists.txt. > > Tested on winxp with msvc7.1, 8.0, 9.0 and cmake-2.4.8/2.6.1. Also > tested to build with nmake generators. Wow, thanks for regression testing that change. I think you covered pretty much all of the bases there so I would go ahead and submit the patch to Robert. > As a side note, without having digged this out I've been wondering > what the OSG_MSVC_VERSIONED_DLL do that OSG_USE_SONAMES don't? I am > prepared to get bitch-slapped here but if it is redundant we should > remove it for easier maintenance. OSG_MSVC_VERSIONED_DLL encodes a version number into DLL filenames generated on WIN32 see HANDLE_MSVC_DLL in OsgMacroUtils (which could use some cleaning up). OPENSCENEGRAPH_SONAMES enables SONAME shared library versioning for platforms that support it (i.e. libfoo.so.1 gets generated instead of libfoo.so and the developer can bump the shared library version number when the ABI changes). -- Philip Lowman
_______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
