Hi Lionel,

I've now had a chance to do a more thorough review, and I "think" your
change is appropriate.  I've been testing it and haven't yet found any
scenes with particle system that don't work fine with your change, and
of course your example model now works.  I'm not the original author
of osgParticle though so feel a bit uneasy about making assumptions
about how it works in the various configurations that one can use it
in.

While I'm a bit uneasy about saying the change is 100%, it certainly
fixes far more than it breaks from the testing I've done, and it seems
to make sense given that particles are placed in world coords, and
have velocity in world coords - overall it looks like the benefits
outweigh the risks, so I've gone ahead and checked this change into
svn/trunk.

These changes really need testing out in the community now, so all
those who have particle systems in their models/apps please test to
make sure nothing has broken.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to