Hi Robert, Yes. I agree with you. Thanks.
John Ivar On Mon, May 18, 2009 at 2:39 PM, Robert Osfield <[email protected]>wrote: > Hi John, > > Man that's frustrating. This really does look a buggy compiler.... > The friend even allowed me make the nested base class private on gcc > 4.3.2, for gcc 3.2 to ignore the friend, and not obey the usual rules > of subclasses having access to protected members is doubly bad. > > I've been reviewing docs on ABI compatibility and moving this nested > class to the public scope would indeed break binary compatibility, so > isn't something we can entertain for OSG-2.8.1. > > Unless someone can spot another way of tricking gcc 3.2 to not > tripping over this code we'll just to accept 2.8.1 won't compile out > of the box under RHEL 3.2, and pointer users at what mods they can > make locally. > > For the 2.9.x series we could possible look at re-organizing the > classes in a way that breaks the ABI, since the ABI is already > incompatible with 2.8.0. > > Robert. > > On Mon, May 18, 2009 at 11:44 AM, John Ivar Haugland > <[email protected]> wrote: > > Hi Robert, > > I used the new ViewDependentShadowTechnique file. The error messages are > the > > same as with the previous version of the file. See below: > > > > [ 34%] Building CXX object > > src/osgShadow/CMakeFiles/osgShadow.dir/LightSpacePerspectiveShadowMap.o > > In file included from > > > /private/jiha/shivr/JIHA/OSG/OpenSceneGraph-2.8.1/include/osgShadow/LightSpacePerspectiveShadowMap:23, > > from > > > /private/jiha/shivr/JIHA/OSG/OpenSceneGraph-2.8.1/src/osgShadow/LightSpacePerspectiveShadowMap.cpp:18: > > > /private/jiha/shivr/JIHA/OSG/OpenSceneGraph-2.8.1/include/osgShadow/ViewDependentShadowTechnique: > > In > > member function `virtual > > osgShadow::ViewDependentShadowTechnique::ViewData* > > osgShadow::ProjectionShadowMap<MinimalBoundsBaseClass, > > > > > ShadowProjectionAlgorithmClass>::initViewDependentData(osgUtil::CullVisitor*, > > osgShadow::ViewDependentShadowTechnique::ViewData*)': > > > /private/jiha/shivr/JIHA/OSG/OpenSceneGraph-2.8.1/include/osgShadow/ViewDependentShadowTechnique:160: > > ` > > struct osgShadow::ViewDependentShadowTechnique::ViewData' is protected > > > /private/jiha/shivr/JIHA/OSG/OpenSceneGraph-2.8.1/include/osgShadow/ProjectionShadowMap:77: > > within > > this context > > > /private/jiha/shivr/JIHA/OSG/OpenSceneGraph-2.8.1/include/osgShadow/ViewDependentShadowTechnique:160: > > ` > > struct osgShadow::ViewDependentShadowTechnique::ViewData' is protected > > > /private/jiha/shivr/JIHA/OSG/OpenSceneGraph-2.8.1/include/osgShadow/ProjectionShadowMap:77: > > within > > this context > > make[2]: *** > > [src/osgShadow/CMakeFiles/osgShadow.dir/LightSpacePerspectiveShadowMap.o] > > Error 1 > > make[1]: *** [src/osgShadow/CMakeFiles/osgShadow.dir/all] Error 2 > > make: *** [all] Error 2 > > > > > > On Mon, May 18, 2009 at 11:24 AM, Robert Osfield < > [email protected]> > > wrote: > >> > >> Hi John, > >> > >> On Mon, May 18, 2009 at 9:52 AM, John Ivar Haugland > >> <[email protected]> wrote: > >> > I tested the new ReaderWriterCURL.cpp. It compiled ok with my system > >> > (libcurl 7.10.6). I also made a test by copying > >> > the cessna.osg file to a web-server with a new name cessna2.osg. The > >> > libcurl plugin seems to work since I was able to access it with a > >> > hyperlink > >> > address. Thanks! :) > >> > >> Thanks for the testing. Most functionality should work, but you'll > >> get codes that that messages on errors, and authentication is not > >> likely to work fully, due to lack of features. For standard web > >> access it should be fine though, and slightly less functionality web > >> access is far better than no web access. > >> > >> On the osgShadow front, I really can't test things out directly so > >> I'll need you to pitch in with testing changes. To try an replecate > >> the problems you are seeing I changed the ViewDependentShadowTechnique > >> to have the ViewData in a private section, this broke the compile of a > >> number of the classes in the osgShadow in what looks to be roughly the > >> same way as your errors. I then added friend class declarations in > >> the ViewDependentShadowTechnique till I got the whole osgShadow > >> compiling again. Thankfully this did work out. > >> > >> I've now changed the private: back to protected: so the ABI should be > >> any different - for the 2.8.0 I'm trying to keep ABI compatibility so > >> this is important. The changed file is attached, could you please > >> apply this and do a new build. Fingers crossed this will fix the > >> build and everything will build for you without any local mods. > >> > >> Could you let me know how you get on so I can move ahead with merging > >> this fix and making... yet another rc... :-) > >> > >> Robert. > >> > >> _______________________________________________ > >> osg-users mailing list > >> [email protected] > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > >> > > > > > > _______________________________________________ > > osg-users mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >
_______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
