Hi Paul,

There is a Vec3ub and a Vec3b, if you want a 0 to 255 range for a
colour then you'd use a Vec3ub rather than a Vec3b.  So rather than
introducing problems I would have though this would avoid them.

Robert.

On Tue, May 19, 2009 at 1:40 PM, Paul Melis <p...@science.uva.nl> wrote:
> Hi,
>
> Regarding rev 10233:
>
> -----------------------
> osg/Vec?b:
>
>  Also changed
>      typedef char value_type;
>  to
>      typedef signed char value_type;
>
>  In the case of a simple "char", SWIG assumes a string.
>  Using "signed char" instead of "char" does not change
>  the behaviour of the class."
> -----------------------
>
> Transforming char to signed char obviously changes the behaviour, as you can
> no longer store values in same range anymore. E.g.
>
> 14:37|me...@juggle2:~/c/osg/svn/branches-2.8> cat t.cc
> #include <osg/Vec3b>
> #include <cstdio>
> int main()
> {
>   osg::Vec3b  col;
>   col.x() = 255;
>   printf("%d\n", col.x());
> }
> 14:37|me...@juggle2:~/c/osg/svn/branches-2.8> g++ -o t t.cc -I
> ~/osg2.8/include/
> 14:37|me...@juggle2:~/c/osg/svn/branches-2.8> ./t
> -1
>
> This seems like a bad idea, as I suspect people are more likely to use Vec3b
> for storing colors values, instead of values in the -127..128 range.
> I would suggest reverting the change and make Vec?b store char's once more.
>
> Regards,
> Paul
>
> Robert Osfield wrote:
>>
>> Hi All,
>>
>> I've just tagged another release candidate, this time we've hit
>> 2.8.1-rc5.  Fingers crossed this will be our latest rc and we can
>> quickly move on to tagging 2.8.1 and get some new binaries posted.
>>
>> http://www.openscenegraph.org/projects/osg/wiki/Downloads
>>
>> Source Code: ¶
>>
>>    source package : OpenSceneGraph-2.8.1-rc5.zip
>>    svn tag: svn co
>>
>> http://www.openscenegraph.org/svn/osg/OpenSceneGraph/tags/OpenSceneGraph-2.8.1-rc5
>> OpenSceneGraph
>>
>>
>> Could users please test out this latest rc5 this afternoon/evening and
>> if things look good on the major platforms I'll tag 2.8.1 tomorrow
>> morning.
>>
>> Thanks for your assistance,
>> Robert.
>> _______________________________________________
>> osg-users mailing list
>> osg-users@lists.openscenegraph.org
>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
>>
>
> _______________________________________________
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to