Hi Wojtek, Arg... I'm working through my osg-submission backlog but didn't spot the thread your submitted the changes on as being connected. I should have read through all the submissions before posting...
I've tracked down the appropriate thread now - I've even commented on the thread last week, so it looks like my memory is not serving me well... But now I'll get on with doing a proper review, thanks for the patience, Robert. On Thu, Aug 20, 2009 at 5:16 PM, Wojciech Lewandowski<[email protected]> wrote: > Hi Robert, > > Weird. I have sent this on 7th of August and it arrived back to me through > osg-users and osg-submissions mailing lists: > > Re: [osg-submissions] [osg-users] FBOs without color or depthattachments > /DrawBuffer/ ReadBuffer > > I wanted to send you a link to forums, but I cannot find it there, though. > However, I have found a post that refers to my submission: > > http://www.mail-archive.com/[email protected]/msg30839.html > > But when I move one post back it moves me to much older post. So its not > available on forums. Where is the problem ? Maybe because it was sent to > both osg-users and osg-submissions ? To be sure I copied it below > (attachment also provided): > > ---- > > Hi Robert and J-S and all interested, > > I have prepared the code for the proposal. There was a bunch of changes to > Camera/SceneView/CullVisitor/RenderStage (and few other files). Its not > exactly like what we planned because practice once again showed the theories > are only work on paper and on the internet;- ). > > I initially have written the code for lazy updates of DrawBuffer and > ReadBuffer to osg::State. But during debugging & reading FBO spec again, I > learned that it does not make sense. OpenGL treats DrawBuffer/ReadBuffers > as members of FBO state. Buffers are not unique per GL context but each FBO > can have them set differently and once FBO is bound its > DrawBuffer/ReadBuffer selection is made active. So it won't work to keep > them in State. > > For the first point of our plan I also had to make modifications. > Fortunately, as planned, camera uses inheritance DRAW_BUFFER / READ_BUFFER > masks. However, RenderStage code seems to not always expect presence of > associated camera that would contain valid DrawBuffer/ReadBuffer settings. > For this case it was neccessary to add _drawBufferApplyMask / > _readBufferApplyMask flags to RenderStage. These flags effectively replace > former case of RenderStage::_drawBuffer/RenderStage::_readBuffer being set > to GL_NONE. These flags are now used to inform RenderStage to inherit / not > touch buffer settings from what was set in prior stage. > > See the attached code for details. I must admit that this modification > eluded me a bit. I hope I did everything properly, but I really count on > peer reviews. > > I have left FORCE_COLOR_ATTACHMENT / FORCE_DEPTH_ATTACHMENT defines in the > RenderStage.cpp. I expect that Robert will take decision to remove them or > keep them for a while. FORCE_COLOR_ATTACHMENT is set to 0 but > FORCE_DEPTH_ATTACHMENT is set to 1. I tested the changes with Viewer > Prerender/ Shadow examples. I noticed that when DEPTH_ATTACHMENT is not > forced, depth tests in Prerender fail and Cow.osg or Cessna.osg are > displayyed with "holes". So it would be necccesary to test all examples > using FBOs and check if they require exlpicit setting of depth attachments. > Once examples are fixed one may turn off FORCE_DEPTH_ATTACHMENT in > RenderStage.cpp. > > Uff, It was bit exhausting. I have spent 3 days on this stuff and I must > admit that it is still undertested. Unfortunatelly, I have to move over to > other activities this week. If it becomes neccessary, I will go back to the > subject after next weekend. Although I doubt I will be able to do any coding > this week but I should be able to stay in touch with forums. I also hope, > that in the meantime You will look at these changes, test them and make > neccessary tweaks or send me requests for aditional changes. > > > ---- > > Cheers, > > Wojtek > > > > ----- Original Message ----- > From: "Robert Osfield" <[email protected]> > To: "OpenSceneGraph Users" <[email protected]> > Sent: Thursday, August 20, 2009 5:34 PM > Subject: Re: [osg-users] Frame rates vary dramatically across runs > Hi Wojtek, > > I've done my best to enjoy my vacation(s!) and now will take joy in > pestering you about the changes we discussed, did you get around to > making them :-) > > Cheers, > Robert. > > On Mon, Jul 27, 2009 at 4:27 PM, Wojciech > Lewandowski<[email protected]> wrote: >> Robert, >> >> I'll try to do it. >> Enjoy your vacations, >> >> Wojtek >> >> ----- Original Message ----- From: "Robert Osfield" >> <[email protected]> >> To: "OpenSceneGraph Users" <[email protected]> >> Sent: Monday, July 27, 2009 4:37 PM >> Subject: Re: [osg-users] Frame rates vary dramatically across runs >> >> >>> Hi Wojtek, >>> >>> On Mon, Jul 27, 2009 at 3:23 PM, Wojciech >>> Lewandowski<[email protected]> wrote: >>>> >>>> I think we are pretty much on the same page. Question (which J-S asked) >>>> is >>>> who does this ? I may not uderstand all the intricacies, but I promised >>>> to >>>> look at the code and come up with submission proposal in next few days. >>>> I >>>> ll >>>> try do to my best, but let me know, if You feel like its better to leave >>>> the >>>> problem for You to solve. >>> >>> I'm just about to head off on another weeks family holiday so I won't >>> be able to take on work right away, so please feel free in diving in >>> and making the required changes. Any changes it'd be worth pushing on >>> to the list to get them tried out. >>> >>> Cheers, >>> Robert. >>> _______________________________________________ >>> osg-users mailing list >>> [email protected] >>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> >> _______________________________________________ >> osg-users mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
