Hi Brad, I can't really say whether you'll see fall out from your mods without seeing them in the flesh and comparing it to the code in svn/trunk. I'll need to review both together as I'll need to refresh myself with all the VPB specifics - I'm not bright enough to retain both the OSG and VPB project codebases in my head all the time so have to sit down and review code in both cases to bring back what on earth each one is supposed to do :-)
Robert. On Wed, Dec 16, 2009 at 8:44 AM, Christiansen, Brad <[email protected]> wrote: > Hi all, > > A quick comment first, it has been a couple of years since I have used > osgdem, and it is great to see it is going so well (as VPB). Thanks > Robert. > > I have been experimenting with the various options for patching an > existing db. One of things I need to be able to is to add more optional > data sets. When I tried to do this vpbmaster complained that the new > options were not compatible with the existing db. > > I couldn't see why what I was trying to do shouldn't work so I simply > commented out the check on optional layers in the > BuildOptions#compatible method. Once this was done, I could successfully > add new optional layer sets with no obvious issues. > > Is my 'fix' something that can be included or I am missing something > that could lead to problems if this functionality is allowed? > > I have also changed the code to allow changing layer inheritance for a > new optional sets. I haven't experimented with this much yet, but it > seems to work ok. Should I expect problems with this? > > Cheers, > > Brad > > > > DISCLAIMER:--------------------------------------------------------------------------- > This e-mail transmission and any documents, files and previous e-mail messages > attached to it are private and confidential. They may contain proprietary or > copyright > material or information that is subject to legal professional privilege. They > are for > the use of the intended recipient only. Any unauthorised viewing, use, > disclosure, > copying, alteration, storage or distribution of, or reliance on, this message > is > strictly prohibited. No part may be reproduced, adapted or transmitted > without the > written permission of the owner. If you have received this transmission in > error, or > are not an authorised recipient, please immediately notify the sender by > return email, > delete this message and all copies from your e-mail system, and destroy any > printed > copies. Receipt by anyone other than the intended recipient should not be > deemed a > waiver of any privilege or protection. Thales Australia does not warrant or > represent > that this e-mail or any documents, files and previous e-mail messages > attached are > error or virus free. > -------------------------------------------------------------------------------------- > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
