Hi J-S, On Thu, Jan 7, 2010 at 2:33 PM, Jean-Sébastien Guay <[email protected]> wrote: >> Re-ordering the code so the input.readAllDataIntoBuffer() is done >> before the if (!input) looks it would be appropriate. I've made this >> change and checked it in, could you test it? > > Seems appropriate yes, as long as readAllDataIntoBuffer() handles the case > where the file was not opened correctly (which it does). > > This seems to work fine.
Good to hear, thanks for the testing. > And what about my other question: > >>> Once I do this in my code (awaiting a good fix to readXmlFile() ), I get >>> errors "end tag is not matched correctly" for items like: >>> >>> <item someattribute="somevalue" /> >>> >>> This is valid XML syntax, but is it not supported by the XmlParser? I >>> could >>> add support for it, but it seems weird that it's not supported... > > I'm looking into this, will probably post a change soon, but it really seems > weird to me that this kind of tag is not supported... It's basic XML syntax. Oo, too much speed reading on my behalf... I missed this part of your email. As for the syntax, I hadn't coded for this as I wasn't familiar with it. I guess that what you get when you get a non XML expert implementing a XML parser :-) I'm busy tackling the submissions so if you can tackle this it'd be great. Robert. _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
