Hi Robert -- This change is generating warnings in several places. Here's an example:

5>..\..\..\src\osg\State.cpp(296) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(303) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(417) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1064) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1068) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1092) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1096) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1113) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1117) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1153) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1157) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1234) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1236) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1262) : warning C4804: '>' : unsafe use of type 'bool' in operation 5>..\..\..\src\osg\State.cpp(1357) : warning C4804: '>' : unsafe use of type 'bool' in operation


Upon investigation, I think we need to change the definition of NOTIFY. It is currently defined as:

#define NOTIFY(level) if (level>isNotifyEnabled(level)) osg::notify(level)

But isNotifyEnabled returns a bool, so you're comparing the notify level against a bool, which is generating the warnings.

I believe the macro should be simplified to:

#define NOTIFY(level) if (isNotifyEnabled(level)) osg::notify(level)

Is this what you intended?
   -Paul

_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to