Hi Robert,

A build issue under Windows was introduced in
src/osgViewer/PixelBufferWin32.cpp : you forgot to replace NOTIFY by
OSG_NOTIFY.

Mourad

On Wed, Feb 10, 2010 at 1:50 PM, Robert Osfield <[email protected]>wrote:

> Hi Paul,
>
> > Hi Robert -- This change is generating warnings in several places. Here's
> an
> > example:
> >
> > 5>..\..\..\src\osg\State.cpp(296) : warning C4804: '>' : unsafe use of
> type
> > 'bool' in operation
>
> Thanks goodness for cross platform build, the warning does reveal a
> typo that gcc didn't pick up on.
>
> > I believe the macro should be simplified to:
> >
> > #define NOTIFY(level) if (isNotifyEnabled(level)) osg::notify(level)
> >
> > Is this what you intended?
>
> YES ;-)
>
> I did original use if (level<getNotifyLevel()) but changed it to use
> isNotifyEnabled(level) as this is better encapsulated.  Alas with this
> change I didn't remove the level< as I should have, dumbo me.
>
> I've now fixed this and checked it into svn/trunk.
>
> Robert.
> _______________________________________________
> osg-users mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to