Hi Alexander,

On 28 June 2014 22:30, Alexander Sinditskiy <[email protected]> wrote:
> I attached file with changes. It builds fine for me.

Thanks for the changes.  Which version of the OSG are you testing
against?  Which version of RVSG are you testing against?

In OSG-3.2 branch the OSG's FindRSVG.cmake doesn't have a version
check for rsvg, while the OSG svn/trunk has a check against
librsvg-2.0>=2.35.

I am wondering if we need both your additions to the
ReaderWriterSVG.cpp and the svn/trunk's FindRVSG.cmake.

Also one item I'm wondering about is the block:

extern "C" {
        #include <librsvg/rsvg.h>

#ifndef LIBRSVG_CHECK_VERSION
        #include <librsvg/librsvg-features.h>
#endif

#if LIBRSVG_CHECK_VERSION(2, 36, 2)
#else
        #include <librsvg/rsvg-cairo.h>
#endif
}

The second #if LIBRSVG_CHECK_VERSION assumes that either rvsg.h
provides this, or the fallback of #include
<librsvg/librsvg-features.h> provide it.  Could there be a case where
neither provide it?

I'
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to