Hi Gianni, I don't recall the decision making process w.r.t the xrandr 1.2 version check, it'll have been quite a few years back. My guess that was the minimum version that looked appropriate at the time.
Just throwing away the version check is unlikely to be generally safe. It'd only be safe if we could confirm that all versions of xrandr in circulation supported the functionality that osgViewer's X11 code paths require. A better solution than just removing the check would be to find the earliest version of xrandr that supports the features we need. I'm curious, what system are you using for it to only have an old version of xrandr? Robert. On 11 November 2015 at 16:07, Gianni Ambrosio <[email protected]> wrote: > Hi, > I'm trying to get the screen refresh rate from > GraphicsWindowX11::getScreenSettings(...). Looking at the code I realized > the point is the xrandr version. In fact supportsRandr() methods require > xrandr version at least 1.2. But since I found the line: > > OSG_NOTICE << "You must build osgViewer with Xrandr 1.2 or higher for > setScreenSettings support!" << std::endl; > > I suspect my xrandr 1.1.1 whould be enough to just read the sceen refresh > rate (and it works fine indeed if remove the xrandr version check!). > Moreover the supportsRandr() check is used just in two methods that simply > read the screen settings while in setScreenSettings(...) it is not used at > all. > > Now, in the actual code (I verified the OSG trunk), the xrand version > check is really required? > > Regards, > Gianni > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=65602#65602 > > > > > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >
_______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
