Hi Julian, Thanks for tracking down the commit. I did a quick search for related discussions on osg-users but haven't spotted anything around the right time frame (late October 2010). There is probably something in osg-submissions and osg-users that discusses this as I don't think it'll be something that I would have applied without some wider issue discussion.
Robert. On 23 May 2016 at 11:15, Julien Valentin <[email protected]> wrote: > Thanks Robert > > According to the git log: > >> commit 57a0065d08b3aa5b06da54a7b78ea2ae36cb2c9a >> Author: Robert OSFIELD <> >> Date: Thu Oct 28 14:04:57 2010 +0000 >> >> Added use ObjectWrapper's FinishObjectReadCallback to fix >> VertexBufferObject handling in osg::Geometry >> and a call to the TileLoaded callback in osgTerrain. >> >> > > > But -and perhaps I haven't investigated enough- I still don't understand what > problem with VertexBufferObject it fixed... > > > > robertosfield wrote: >> Hi Julian, >> >> I have a vague recollection that this callback had to be used to force >> the VBO to be built or something along those lines. Off the top of my >> head I don't recall the exact problem that instigated the change and >> the contributor that came up with this solution. Perhaps git log for >> the files in question might help piece together why it's done. >> >> Robert. >> >> On 20 May 2016 at 17:35, Julien Valentin <> wrote: >> >> > Hi,all >> > I would like to provide osg TransformFeedback serialization feature but >> > something weird forbid BufferObject serialization: >> > This callback calls setUseVertexBufferObjects(false) and just kill all >> > BufferObject attached the geometry's BufferDatas >> > >> > >> > Code: >> > struct GeometryFinishedObjectReadCallback : public >> > osgDB::FinishedObjectReadCallback >> > { >> > virtual void objectRead(osgDB::InputStream&, osg::Object& obj) >> > { >> > osg::Geometry& geometry = static_cast<osg::Geometry&>(obj); >> > if (geometry.getUseVertexBufferObjects()) >> > { >> > geometry.setUseVertexBufferObjects(false); >> > geometry.setUseVertexBufferObjects(true); >> > } >> > } >> > }; >> > >> > >> > I don't understand the utility of this callback (surely because I want to >> > remove it:) ) >> > Does anyone know its purpose? >> > >> > Thank you! >> > >> > Cheers, >> > Julien >> > >> > ------------------ >> > Read this topic online here: >> > http://forum.openscenegraph.org/viewtopic.php?p=67181#67181 >> > >> > >> > >> > >> > >> > _______________________________________________ >> > osg-users mailing list >> > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> > >> _______________________________________________ >> osg-users mailing list >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> >> ------------------ >> Post generated by Mail2Forum > > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=67204#67204 > > > > > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
