Hi Hartwig, If I were starting from scratch on a new project I would opt for different types in certain places in the OSG, for the current version of the OSG we need to be careful about changes that break ABI, or provide any risk of errors being made during changes. Warnings on certain build platforms might be slightly annoying for some users, but bugs and build breaks are major stumbling blocks for everyone - the later is what I use a metric for software quality not cosmetic changes to quiet benign warnings.
Robert. On 29 December 2016 at 21:36, Hartwig Wiesmann <[email protected]> wrote: > Hi, > > I know that these compiler warnings are not critical but I find them still > annoying and I think it is also not a good programming style to use the > "wrong" integer type. > > I also know that a simple modification might break some code (especially for > virtual methods). But wouldn't it be in general a good idea to replace the > mostly "unsigned int" types with size_t? Especially in constructors where > very often a size is passed size_t can be used without problems (all STL > size() methods return size_t types as a default type). > > Cheers, > Hartwig > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=69802#69802 > > > > > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
