Hi Robert, Minor build error on Windows. Missing "extern OSGDB_EXPORT" on the function change in ReadFile. Once I fixed that -- https://github.com/openscenegraph/OpenSceneGraph/pull/525 -- everything in your change works great. Thank you,
- Dan -----Original Message----- From: osg-users [mailto:[email protected]] On Behalf Of Robert Osfield Sent: Thursday, April 05, 2018 9:23 AM To: OpenSceneGraph Users Subject: Re: [osg-users] OpenScenGraph 3.6 release candidate 5 tagged Hi Dan, On 5 April 2018 at 13:18, Daniel Emminizer, Code 5773 <[email protected]> wrote: > Looking good so far here with testing on GL Core 3.3. Main concerns is that > it's noisy on the console. You just pushed a commit that helps with this in > DisplaySettings::setShaderHint(). But I still see: Thanks for the testing. > 1) osgText prints errors about "Error reading file shaders/text.frag: file > not found", but correctly falls back to built-in shader. Same with > text.vert. One fix for this is to use a custom version of > readRefShaderFileWithFallback() in osgText/Text.cpp but obviously that's > messy. > > Other options include requiring end user apps to always package those files, > or to always intercept the search with osgDB tricks. > > > 2) Drawable::createVertexArrayStateImplementation() still has an OSG_NOTICE > that spams the console in some of our apps. Would recommend OSG_INFO or > commenting out. I have checked in a fix for this noisy debug output: https://github.com/openscenegraph/OpenSceneGraph/commit/914e60a8723b0306daef7dd7d8b3839f4b84d84b > No other concerns at this point. Thank you for the excellent software. Cheers :-) Robert. _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
