Hi Dmitry,

I just tried your fix with the Puget sound data and understand what you
mean when you say things are flipped around the Y-axis now.  I'd like to
run it through some sample datasets when I get back to work on Monday to
make sure it holds up, but it looks pretty good to me,

Jason


-----Original Message-----
From: [EMAIL PROTECTED] on behalf of Dmitry Platonov
Sent: Sun 9/17/2006 8:21 AM
To: osg users
Subject: Re: [osg-users] osgTerrain DataSet bug?
 
Hi Robert, Jason!

My gdal version:
$ gdalinfo --version
GDAL 1.3.2.0, released 2006/05/02

I think i tracked down this bug. Please look at use of any 
RasterIO at DataSet.cpp, for example:

bandSelected->RasterIO(GF_Read,windowX,_numValuesY-(windowY+windowHeight
),windowWidth,windowHeight,heightData,destWidth,destHeight,GDT_Float32,0
,0);

Note third argument. Now in getInterpolatedValue:
band->RasterIO(GF_Read, colMin, rowMin, 1, 1, &llHeight, 
1, 1, GDT_Float32, 0, 0);
band->RasterIO(GF_Read, colMin, rowMax, 1, 1, &ulHeight, 
1, 1, GDT_Float32, 0, 0);
band->RasterIO(GF_Read, colMax, rowMin, 1, 1, &lrHeight, 
1, 1, GDT_Float32, 0, 0);
band->RasterIO(GF_Read, colMax, rowMax, 1, 1, &urHeight, 
1, 1, GDT_Float32, 0, 0);

Apparently, here RasterIO is used in other way.
After trivial change:

band->RasterIO(GF_Read, colMin, _numValuesY-(rowMin+1), 1, 
1, &llHeight, 1, 1, GDT_Float32, 0, 0);
band->RasterIO(GF_Read, colMin, _numValuesY-(rowMax+1), 1, 
1, &ulHeight, 1, 1, GDT_Float32, 0, 0);
band->RasterIO(GF_Read, colMax, _numValuesY-(rowMin+1), 1, 
1, &lrHeight, 1, 1, GDT_Float32, 0, 0);
band->RasterIO(GF_Read, colMax, _numValuesY-(rowMax+1), 1, 
1, &urHeight, 1, 1, GDT_Float32, 0, 0);

everything works like charm.

Problem I described earlier appears in every dataset I 
tried, (1k, 4k & 16k Puget sound, bluemarble 21k, 
artifical testcases). Using geotransform/geotiff info, I 
believe it's possible to workaround it, but on any 
matching texture/heightmap pair with same transforms this 
bug should result in flipped mesh vs texture.


On Sun, 17 Sep 2006 10:12:56 +0100 "Robert Osfield" 
<[EMAIL PROTECTED]> wrote:
>Hi Jason,
>
>The error I'm seeing looks like a flipping around the Y 
>axis, rather than a
>small shift you report. I used the 4k imagery as Dmitry 
>and you used.
>
>After sending my last post yesterday it occured to me 
>that perhaps its GDAL
>that is the problem, as your code looked fine, relying 
>upon GDAL to get the
>data correctly.  The fact that you aren't see the the Y 
>axis flip perhaps
>could another hint that the problem is in GDAL, but has 
>been fixed already.
>
>What version of GDAL are you guys using?
>
>This is my version:
>
>gdalinfo --version
>GDAL 1.3.1.0, released 2005/10/04
>
>Robert.
>
>On 9/17/06, Jason Beverage <[EMAIL PROTECTED]> 
>wrote:
>>
>> Robert,
>>
>> I don't have time tonight to download and run the high 
>>res Puget Sound
>> data but I got the 4096 texture and 4096 heightfield to 
>>do a quick test.
>> I ran osgdem on the png's and I'm not seeing any 
>>flipping around the y
>> axis on that data set.  I tried setting 
>>interpolateTerrain to false and
>> their is only a slight change in the position of the 
>>terrain, but
>> nothing I would call "flipping around the Y axis".
>>
>> The alignment of the texture to the heightfield is a 
>>little off when
>> interpolateTerrain is set to true though, if that is 
>>what you all are
>> referring to.  I can see where the whitest part of the 
>>texture should be
>> at the top of the peak on the right of the dataset, but 
>>with
>> interpolateTerrain on, it is slightly off.  The reason 
>>for this is
>> because the changes I made only applies to terrain, not 
>>to imagery, so
>> the sampling method in readHeightField is different than 
>>in readImage.
>> If that is what the problem is, let me know and I'll see 
>>what I can do.
>> Jason
---
Professional hosting for everyone - http://www.host.ru
_______________________________________________
osg-users mailing list
[email protected]
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/



begin 666 winmail.dat
M>)\^(A\``0:0" `$```````!``$``0>[EMAIL PROTECTED](````Y 0```````#H``$(@ <`
M& ```$E032Y-:6-R;[EMAIL PROTECTED];"Y.;W1E`#$(`0V ! `"[EMAIL PROTECTED]"``$$
M@ $`* ```%)%.B!;;W-G+75S97)S72!O<V=497)R86EN($1A=&[EMAIL PROTECTED]
M/P#R#0$%@ ,[EMAIL PROTECTED]'"0`1`!0`,0`W````<P$!(( #``X```#6!PD`$0`4
M`#0`'@```%T!`0F `0`A````,40R,40P13<Y-4,P1# T,D%&1C5&-$4S,#8V
M-D0P0S,`,P<!`Y &`$P1```Y`````P`F```````#`#8``````$ `.0#?V:];
MO-K&`1X`/0`!````!0```%)%.B [EMAIL PROTECTED]'``$````P````8SU54SMA/2 [
M<#U04D],3T=)0SML/59!1$52+3 V,#DQ.# P-3(S,%HM,S,P,C0`'@!)``$`
M```H````4F4Z(%MO<V<M=7-E<G-=(&]S9U1E<G)A:[EMAIL PROTECTED]&%T85-E="!B=6<_
M`$ `3@" 27/'4]K&[EMAIL PROTECTED])0```&]S9RUU<V5R<RUB;W5N8V5S0&]P
M96YS8V5N96=R87!H+FYE= `````"`5L``0```&<[EMAIL PROTECTED]
M;@[EMAIL PROTECTED]<V<M=7-E<G,M8F]U;F-E<T!O<&5N<V-E;F5G<F%P:"YN
M970`4TU44 !O<V<M=7-E<G,M8F]U;F-E<T!O<&5N<V-E;F5G<F%P:"YN970`
M``(!7 [EMAIL PROTECTED] Z3U-'+55315)3+4)/54Y#15- 3U!%3E-#14Y%
M1U)[EMAIL PROTECTED]'@!=``$````0````1&UI=')Y(%!L871O;F]V``([EMAIL PROTECTED]
M````00````````"!*Q^DOJ,0&9UN`-T!#U0"`````$1M:71R>2!0;&%T;VYO
[EMAIL PROTECTED]'-H861O=VIA8VM >FUA:6PN<[EMAIL PROTECTED]
M4#I32$%$3U=*04-+0%I-04E,+E)[EMAIL PROTECTED] `````
M'@!G``$````E````;W-G+75S97)S+6)O=6YC97- ;W!E;G-C96YE9W)A<&@N
M;F5T`````!X`: `!````!0```%--5% `````'@!I``$````4````<VAA9&]W
M:F%C:T!Z;6%I;"YR=0`>`' ``0```"0```!;;W-G+75S97)S72!O<V=497)R
M86EN($1A=&[EMAIL PROTECTED]/P`"`7$``0```!L````!QMI3?L<\I6I"P]Y.-XP!
M*!2%/TG!`!HW.N8`'@!T``$````*````;W-G('5S97)S````'@`:# $````/
M````2F%S;[EMAIL PROTECTED])A9V4``!X`'0X!````) ```%MO<V<M=7-E<G-=(&]S
M9U1E<G)A:[EMAIL PROTECTED]&%T85-E="!B=6<_``(!"1 [EMAIL PROTECTED]"-$P``3%I&
M=8];=J #``H`<F-P9S$R->,`4 -2=&5X!4$!`P'W_PJ `J0#Y <3`H /\PY1
M!&4W"%4'LA$E,@[EMAIL PROTECTED]:.$*P'-E=#(&``;#$27V,P1&$[<P$BP1,PCO"?>V
[EMAIL PROTECTED] U$2(,8&,`4#,+"0%D,S864 NF([EMAIL PROTECTED]:2!$;6ET<GD.+ 
JB"[EMAIL PROTECTED]@
M:G6.<P5 '5 (D&0@>0AA("!F:7@@`_!T:($>L&AE([EMAIL PROTECTED]"!S"&!N'P!D
M80&0?B `<!\`(,$$D!Z0(5)W]Q/@!4 ?(2 '@ .1(D )[EMAIL PROTECTED]>1_Q"X!G
M!"#3"L @(&9L!2!P'O$*P$,@LR "62UA> 0`( !N;W<N("!))PL?`"2P:R @
M=&\@<[EMAIL PROTECTED]" =0!_Q)3%G'^ @H/L'@".A;0M0(" A`A01!"!7(R,>4"[EMAIL 
PROTECTED]
M:R<B=_\%L"J `B %T (@(0`CT2= NP# )P%S"' @(">A: ;PHF0$('5P+"I 
M=05 TR>A%[!O:P0@<!@@`D!=(]!G+> E<2O191V+2J\I0 (@'9H=E"[EMAIL PROTECTED]
M$/YG"X '0 70!Y CL"!@,8,5'91&`V$Z*Q!S9RU;'H AP2T&X"# 8P>00$YO
M). [EMAIL PROTECTED] ;F4)P&$X<&@N-7 %0"LA8F7Y$^!L9BL0-K =)" P"V![)S F0'8=
ME [EMAIL PROTECTED] SP%-!)W$Y+S$W+P'0,$ V([EMAIL PROTECTED],C$0P$UY'914;S/#(8 
T,C?U=4QB
M:@60.(%293/ 6_4SYUTSTE0$D#6@"X [EMAIL PROTECTED]@4#\=E KC"H"_'/$(
[EMAIL PROTECTED]" M0# 3(1V:[EMAIL PROTECTED](<%I`B"Z.AV4)$%3"X "$" Q@ -!M1V4
M1T1!3" QP"XS+C(N,"U &""/*. I01\`.4(O,#5%X/\34!VK(_([EMAIL PROTECTED]'5 J
M81[Q_F0F4 .@(_$$(#Y1)G W</]%0BW#(4 %0#0A-L(`<"/0C1V44BE #K!R
M24])POT]U2X-\"TQ`A %P [ *+/_0B4=E"I0(- &8"[EMAIL PROTECTED] )@(0M/DL6*$=&
[EMAIL PROTECTED]&%D+ /P(- [EMAIL PROTECTED] *4',E)= H4!19*U 42&41,?!H="E0
M!5=I9'<?T% %4D0L(!!28CW2+#\!`!Z04R15`E/E1#!47T9&%[ A$#,R+$3@
M,.8I&3 =J4YO#K [EMAIL PROTECTED]@_2119U"P.&$F<%@@!^ ]H>[EMAIL PROTECTED]", 20< 
;P(1 )
[EMAIL PROTECTED](E3B).[T_P(!>[EMAIL PROTECTED])E!=0S%=\R9LWFQ3Y3[U7A166B!$X5<W
MWUN?7*]=L"[EMAIL PROTECTED]'/7/1CLEV><F2/99__9J]GOVC+8[IJ7VMO
M;'H=E.Y!)- D80(P;!UP++ $D/\@($L7)A$T(1\`/:%8,'0Q>Q^@(\ N<Q4!
[EMAIL PROTECTED]'L%V_P<Q70`3X"[EMAIL PROTECTED];US:4)OY790K,[EMAIL 
PROTECTED]@)PQUYY<2__;%]Y#WH?
M>RHE\'P/9%E]S_]^WW_O:)J!OWOO:AN$KX6_?X;/A]^"#X,>BO^,#QV:97U!
ML7DC\RK#!" FXQ/2;9MV51V44 [EMAIL PROTECTED];2GAWU4!!0$V8!\`(N!R)+ [EMAIL 
PROTECTED]
ML"[EMAIL PROTECTED] H,6LM0#0J@/HF1' V*H @22U!"D$`P+YR
MEV%%D)N"'90*P'0&D#\-X#(Q#K >D)[EMAIL PROTECTED]<%4`D)4Q(&!8,[EMAIL 
PROTECTED](#Y
M3*%M+Z!"!I VL$+R+4#?FH8V8)BA0; GD2<N$3/@_P"0G9(JI24E'4 M1"LA
M2GC?`,"?4)43#K(L42]45 # _G N( [EMAIL PROTECTED])Q&@AO\$($AS3<[EMAIL 
PROTECTED]""0
M+,!D8!\`^Q@@+$!L+8$#H"2F!X$?X-YVJ3&FI)9K'91/`Z XL1U=\3<&4:>0
M.4,Q,#K)#B Z-3EP*S"O,!90<B(_E"!/H+ (D"S@(FT^]3R703_!+C/@L,- 
MWF<`P ,03$ #<#X?H [EMAIL PROTECTED]'/$P$QV%/[EMAIL PROTECTED];$FH)>0%!!2
M4/^5,2W4)N,A,"2CE2(E*C[U?CXE\D3Q(1!UXA_0`Y%A_;.E<P# 7H"J,0:0
M(G08(/]:8+'A*>%U0R "F\$'<#*A_S=!*4 V]KD&(-$BDG5"=E7?M09VQ!00
M(-"5(FTCT [EMAIL PROTECTED]<541!) [EMAIL 
PROTECTED]>A;_QC8RQ1+M6X]KI!P?$$D/T3X'"9
M42EQ1#+$&B81( +_+C"74RU O?$?([EMAIL PROTECTED]>\1]P-7!$\WF5(K.E+2#_
M*R%$,R<Q(&(@`;.E(0,%H=\8(#O@<_ F<;6"[EMAIL PROTECTED])[+[(F5SHB<@@0G@'_.X
MKR23_\3&LZ4%H*IR`'!UQ"0!S55_QLEU`CVA1#(M1!/@J88^_S9@(T$?<23R
M:D!/T79&M0;^5R)20;4VPD0S)&(BDECP_GEU(B01/H6U"-."!"#!D>]!O+4&
M0K\P53Y$-T2 1.WW1@"O,[EMAIL PROTECTED]/Y2_S:WQ9SCS.6 _]2!"E+(RH2#L/&HV
M8./$0,<!%[ R`/1C+0N 8[+DLZ6S2[4&_[,@/Y7FWY>Q`B#.01/@HL'_GJ"H
M<@(@4F(G([EMAIL PROTECTED]'[EMAIL PROTECTED]( (D`"@AZ%:JL2 
U_E,@LN=7(0,M8BGQ6#"\
M]/PP.3EPII4A0_ #5%2PP\\G(NA62""W<7%U#> [EMAIL PROTECTED];_&Z4*@@3/2`0"7
MD"LA_\;#)""C$2%2MB+1L;962GCWYS"WKR 1>>=7)?/U,R)A?R$#%!$F<AZU
M%!&>H,F(/M_2,5I&/58G,<T@;$E1(5&_YU<@`:?1^?-S\+=Q<R2P_^K"=Z19
MHL;#,^ =0-?5( +_Z%9+03V"+4/G5]&RE2(>4.\JT*IRGN%W@"+W_[BS)?*>
M(O/'YU>[EMAIL PROTECTED]")O!6)S'L0_%Y)A$A, >6_R2P^_ HX3;0-K C(N=7
M_-__)X'4H)I""G(G8%A2* (M0/^A4,UDJ7?G,")'NS(D8>=7[1@@9CUAIE-O
M^R.>X+IP_\YR(R$*0B 1(D LD%41IZ'_L'$"/_!TJD4V8/E(TJ0G,/^GD!95
MF1$K`R ",>'JT195_RD5+4011Q_!#6_]6;1Q)Y+_#R(`8P`!#.',M=8!XV+W
M=_],L4AS)[EMAIL PROTECTED]>DU*#T8+V R#'_Y*N F*'[EMAIL PROTECTED],V]H("
MIR5PO74M0/^<L/[*J$(E`<%B6? LP'5S^]8"4D1&"U;[EMAIL PROTECTED]'21/LA""F5
M2;V"\\D0J!'#TLSOI- ,L$NPP^%K-\!9D/8$_[M"SH$12Q1$2"#SR$ 3/I3]
MW4 MEM<3<*-AXW!W<1 @O\(PE2),HY3"XW!T8"UT($'[\' Z+R]W-S N[352
M+NP`/I1?.$\Y7SHJ^SZ4/2$M2@&90;*BMI/Y\'[EMAIL PROTECTED]"7\ U 9>)G
MN=!P:"[(\ /5-L69/?]T+[*BO8!N+SRR?]SR/] [IC\;-S(_[4RP9PHO1DI]
M1< ``!X`-1 !````0 ```#PR1$)".48X.#=$04$S.31&03<U1#DX-#<T14$U
M-S,P1#4R-T5%.4!V861E<BYP<F]L;V=I8RUI;F,N8V]M/@`>`#D0`0```"$`
M```\=V5B+3(R,3(X.3$V.4!Z8F%C:V5N9#$N86AA+G)U/@`````>`$<0`0``
M``\```!M97-S86=E+W)[EMAIL PROTECTED],@``"P#R$ $````?`/,0`0```& ```!2`$4`
M)0`S`$$`( !;`&\`<P!G`"T`=0!S`&4`<@!S`%T`( !O`',`9P!4`&4`<@!R
M`&$`:0!N`" `1 !A`'0`80!3`&4`= [EMAIL PROTECTED]&(`=0!G`"4`,P!&`"X`10!-`$P`
M```+`/80`````$ `!S#?V:];O-K&`4 `"[EMAIL PROTECTED]&`0,`WC^O;P```P#Q
M/PD$```>`/@_`0````\```!*87-O;B!"979E<F%G90```@'Y/P$```!/````
M`````-RG0,C 0A :M+D(`"LOX8(!`````````"]//5!23TQ/1TE#+T]5/49!
M25)-3TY4+T-./5)%0TE0245.5%,O0TX]2D)%5D5204=%```>`/H_`0```!4`
M``!3>[EMAIL PROTECTED]:6YI<W1R871O<@`````"`?L_`0```!X`````````W*= 
MR,!"[EMAIL PROTECTED]@@[EMAIL PROTECTED],`_3_C! ```P`90 `````#`!I 
M``````,`'4 ``````P`>0 `````>`#! `0````H```!*0D5615)!1T4````>
M`#% `0````H```!*0D5615)!1T4````>`#) `0```"4```!O<V<M=7-E<G,M
M8F]U;F-E<T!O<&5N<V-E;F5G<F%P:"YN970`````'@`S0 $````4````<VAA
M9&]W:F%C:T!Z;6%I;"YR=0`>`#A `0````H```!*0D5615)!1T4````>`#E 
M`0````(````N`````P!V0/____\+`"D```````L`(P```````P`&$%IU(2D#
M``<0G P```,`$! ``````P`1$ `````>[EMAIL PROTECTED]&4```!(241-251262Q)
M2E535%12245$64]54D9)6%=)5$A42$5054=%5%-/54Y$1$%404%.1%5.1$52
M4U1!3D172$%464]5345!3E=(14Y93U5305E42$E.1U-!4D5&3$E04$5$05)/
M``````(!?P`!````0 ```#PR1$)".48X.#=$04$S.31&03<U1#DX-#<T14$U
E-S,P1#4R-T5%.4!V861E<BYP<F]L;V=I8RUI;F,N8V]M/@#,[EMAIL PROTECTED]
`
end
_______________________________________________
osg-users mailing list
[email protected]
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/

Reply via email to