I now have me clean build, and everything works fine with the below methods commented out. I'm ready to pull the trigger and remove these from the distribution. I'll wait a couple more hours for feedback before doing the actual removal though.
I've added a stub for the GUIEventHandlerVisitor for backwards compatibility w.r.t building event handler which define the deprecated accept(GUIEventHandlerVisitor&) method. In the examples I've removed all the previous aceept() from the handlers, and checked these change in already. As I said before these parts of the API weren't being used so removing them has made no funcitonal difference.
I await your comments, but if there are non I'll assume that its fine to go ahead and remove them. This will requie updates to the Xcode projects though, so I'll need Eric or A.N.Other to this for me.
Cheers,
Robert.
On 10/5/06, Robert Osfield <[EMAIL PROTECTED]> wrote:
Hi All,
Towards the cause of making the OSG easier to understand, use and maintian I'd like to clean out some of the unused API in osgGA, the parts I'm looking at removing are:
include/osgGA/SetSceneViewVisitor
include/osgGA/GUIEventHandlerVisitor
And from include/osgGA/GUIEventHandler
class CompositeGUIEventHandler
I have just #ifdef'd these classes out, and am awaiting a clean build of the OSG. These files/classes were written with the expedation that they'd be useful, but as it turned out they weren't required to implement things in viewer code. I presume that OSG end users haven't found for the need them either?
If you do rely on these classes should now, otherwise I'll move to remove them completely. If it later does turn out you relied upon them, then I think there is pretty good chance that only a small number of code changes will be required.
Thoughts?
Robert.
_______________________________________________ osg-users mailing list [email protected] http://openscenegraph.net/mailman/listinfo/osg-users http://www.openscenegraph.org/
