On 19 January 2012 10:17, Richard Hansen <[email protected]> wrote: > > release() and outputRelease() have been designed to support re-use. I >> don't think I've tested it, but I believe it will work. The two >> variables you mention are initialized near the start of those methods >> and only read after the xxxxReleased flags have been set so their >> initial state isn't important. However I can see that is confusing so >> I've modified their initial state to match their final state of true >> (I'll check it in shortly). >> > > I agree with that change. The only other thing I would suggest is a > comment indicating that the class is designed to support reuse. (Or are > all tasks supposed to be reusable?)
These days I try to support re-use for all tasks, but I wouldn't be surprised if many of the older tasks don't work. I've updated the comments to describe the re-use support. Let me know if it doesn't make sense. Brett
_______________________________________________ osmosis-dev mailing list [email protected] http://lists.openstreetmap.org/listinfo/osmosis-dev
