On Sat, Dec 15, 2012 at 5:23 PM, Paweł Paprota <[email protected]> wrote: > Hi Toby, > > > On 12/14/2012 03:40 AM, Toby Murray wrote: > >>> >>> Sure but in this case I would suggest naming this option >>> differently because setting keepInvalidWays to false implies that >>> there will be no invalid ways in the database which may not be true >>> with the current implementation of this option. >> >> >> Well technically there is a difference between way validity and >> linestring validity :) >> > > Yeah, I am/was using the term way/linestring interchangeably... In any case > my opinion is that naming this option keepInvalidWays is a bit of a stretch > since it can lead to dangerous assumptions like assuming that all way > geometry (linestrings) are valid which is not correct. > >> I still think the code I have right now is useful. The biggest plus >> is that it creates consistency between what happens during import >> and what happens during diff application. And it takes care of a >> vast majority of the problem cases at the cost of (more or less) one >> if statement. >> > > Sure, I'm not saying it's not useful, I just have a small problem with > naming since invalid geometry gave me *a lot* of headaches one time and I > would prefer to have it very clearly documented. > > Ultimately it is up to you and/or Brett as the maintainer to decide how to > name it, I can always add some note to wiki documentation about this so all > in all it's not a big deal.
Guess I never replied to this. I would have no problem changing the name of the option. I just couldn't think of anything that makes sense and is reasonably short. Suggestions? :) I was planning on adding this option to the detailed usage wiki page with some text that hopefully explains things clearly. Toby _______________________________________________ osmosis-dev mailing list [email protected] http://lists.openstreetmap.org/listinfo/osmosis-dev
