Hi Toby, On 30 December 2012 18:45, Toby Murray <[email protected]> wrote:
> On Sat, Dec 29, 2012 at 5:01 AM, Brett Henderson <[email protected]> wrote: > > > > > > As for the name of the option, I don't mind too much. I'm personally > happy > > to leave it as it is, largely because I can't think of a better name. > I'd > > rather see efforts go towards improving its behaviour to detect more > invalid > > ways than trying to more accurately name the option to describe its > > limitations. > > Odd... They weren't failing for me. Oh well, at least it was something > simple. > Is it possible you changed the data after you initially ran the tests? Tests only run again if a change is detected. Perhaps the data files are not included in this change detection?? > I have just added this option to the 0.42 detailed usage page on the > wiki since I assume that is where this feature will show up in. > Example: > > http://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage_0.42#--write-pgsql_.28--wp.29 > > > I added it to the --write-pgsql-dump and --write-pgsql-change tasks as > well. I specifically defined what is meant by "invalid way" and made a > note about invalid linestrings coming from other conditions besides > what is addressed by this option. > Yep, looks great. Thanks! I modified it slightly from: Note that invalid linestrings can come from other sources like ways with multiple nodes at the same location. to: Note that invalid linestrings can come from other sources like ways with multiple nodes at the same location, *but these are not currently detected and will be included*. Feel free to update it again if that's incorrect or misleading. Brett
_______________________________________________ osmosis-dev mailing list [email protected] http://lists.openstreetmap.org/listinfo/osmosis-dev
