Thanks Clive,

I have applied the patch.

However I retained the old max(lval,rval) behaviour. Mean value has been 
used earlier and it is known to cause more annoying side effects than 
max value.

Best regards,

Hannu

Clive Wright wrote:
> Ganging MIXT_STEREOSLIDER16 controls in ossxmix causes left channel to
> go to full volume and right channel to be muted although this action is
> not apparent from inspection of the slider controls.
>
> The problem is caused by the GangChange function using 8 bit shift and
> mask instead of 16 bits.
>
> The attached patch corrects this error and provides two other changes:
>
> 1. The function returns without taking any action in the trivial case
> where (lval == rval).
>
> 2. The previous behaviour raised the channel with the lowest volume to
> that of the highest. In some circumstances this could cause annoyance.
> The new behaviour sets both channels to a mean value.
>
> regards,
> Clive
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> oss-devel mailing list
> oss-devel@mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel

_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Reply via email to