20.10.2010 1.18, Yair K. kirjoitti: > On Tuesday 19 October 2010 19:13:08 Hannu Savolainen wrote: >> Hi, >> >> I was out of town at that time and forgot to recheck my mail after that. >> Applied now. >> >> Best regards, >> >> Hannu >> --- > > Thanks. It seems I missed that it warns on 32bit, and the attached patch > fixes > this (and adds some consts).
I haven't followed this list, or OSS development, for long, but if I may comment on just a few things anyway: I think it's vastly better to use the one-patch-fixes-one-problem approach. The commit messages (and hg log) becomes much easier the follow, and actually useful. Also, sending gzipped patches to a ml is not so good, because they (1) can't be read without jumping through hoops and (2) can't be commented on. Regards, Heikki Lindholm _______________________________________________ oss-devel mailing list oss-devel@mailman.opensound.com http://mailman.opensound.com/mailman/listinfo/oss-devel