On Wednesday 20 October 2010 06:59:07 Heikki Lindholm wrote:
> I haven't followed this list, or OSS development, for long, but if I may
> comment on just a few things anyway: I think it's vastly better to use
> the one-patch-fixes-one-problem approach. The commit messages (and hg
> log) becomes much easier the follow, and actually useful. Also, sending
> gzipped patches to a ml is not so good, because they (1) can't be read
> without jumping through hoops and (2) can't be commented on.
>
> Regards,
> Heikki Lindholm
Thanks for commenting, will do this from now.
Attached is a fix for a typo I made which hurt FreeBSD build.
Yours,
Yair K.
diff -r e300d16046f7 os_cmd/FreeBSD/ossdetect/ossdetect.c
--- a/os_cmd/FreeBSD/ossdetect/ossdetect.c Wed Oct 20 04:14:01 2010 +0300
+++ b/os_cmd/FreeBSD/ossdetect/ossdetect.c Thu Oct 21 01:02:32 2010 +0200
@@ -148,7 +148,7 @@
}
/* Drivers with upper case names are unsupported ones */
- if ((*line >= 'A' && *line <= 'Z') || (*line == '\0))
+ if ((*line >= 'A' && *line <= 'Z') || (*line == '\0'))
continue;
driver = line;
_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
