Geraldo, I applied your patch and built it like this: ./scripts/build image=twemproxy
Now when I tried to run it I got an error about empty command line. This app has missing module.py - this could suffice: from osv.modules import api default = api.run(cmdline="/nutcracker") Even though this made it work I noticed that every single time I build this app it would fetch all sources and recompile all over. So that -c does not really help. I think makefile blindly deletes all results after every run. Also I think that there are some other problems with this Makefile. I understand that this part probably always worked like this but given that we are touching this app it would be nice to clean it up (https://blog.codinghorror.com/the-broken-window-theory/). Would you mind running relevant tests before submitting a patch? In case of anythings under apps it is sufficient to build it (./script/build image=<app>) and run it (./scripts/run.py) and ideally test an app (for example using curl if app has HTTP api). In case of OSv main source tree ./script/build check which runs all unit tests should be sufficient. I noticed that some other apps did not work too. Best regards, Waldek On Tuesday, January 16, 2018 at 2:45:28 PM UTC-5, Geraldo Netto wrote: > > Signed-off-by: geraldo netto <[email protected] <javascript:>> > --- > twemproxy/GET | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/twemproxy/GET b/twemproxy/GET > index fff0cdd..85a6697 100755 > --- a/twemproxy/GET > +++ b/twemproxy/GET > @@ -2,7 +2,7 @@ > > rm -f master.zip > rm -rf twemproxy-master > -wget https://github.com/twitter/twemproxy/archive/master.zip > +wget -c https://github.com/twitter/twemproxy/archive/master.zip > unzip master.zip > cd twemproxy-master > > -- > 2.7.4 > > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
