On Sat, Feb 17, 2018 at 10:38 PM, Waldek Kozaczuk <[email protected]> wrote:
> Geraldo, > > I applied your patch and built it like this: > ./scripts/build image=twemproxy > > Now when I tried to run it I got an error about empty command line. > This happens because some applications were only ever tested with Capstan, so they only have a "Capstanfile", not a "module.py". It will of course be nice to fix this lack. > This app has missing module.py - this could suffice: > > from osv.modules import api > > default = api.run(cmdline="/nutcracker") > > Even though this made it work I noticed that every single time I build > this app it would fetch all sources and recompile all over. So that -c does > not really help. > Of course, this was my main comment about many patches in this series, until I bailed out on reviewing them... If the Makefile (or in this case, the "GET" script it runs) has rm -f master.zip wget https://github.com/twitter/twemproxy/archive/master.zip Adding "-c" to this wget is completely pointless. Like you, I'm not suggesting that Geraldo must fix it, but I am suggesting that adding "-c" is pointless, and we shouldn't commit such a patch (if you already did, don't worry, no need to revert it either). Nadav. -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
