Hello Nadav/All,

I just submitted a patch that is based on  Josiah Worcester patch for musl:
http://www.openwall.com/lists/musl/2015/06/17/1

It works as expected:
netto@vmx01 ~/osv-clean $ scripts/run.py -V -e ash
OSv v0.24-489-g3397bd1
4 CPUs detected
Firmware vendor: SeaBIOS
bsd: initializing - done
VFS: mounting ramfs at /
VFS: mounting devfs at /dev
net: initializing - done
vga: Add VGA device instance
eth0: ethernet address: 52:54:00:12:34:56
virtio-blk: Add blk device instances 0 as vblk0, devsize=10737418240
random: virtio-rng registered as a source.
random: <Software, Yarrow> initialized
VFS: unmounting /dev
VFS: mounting zfs at /zfs
zfs: mounting osv/zfs from device /dev/vblk0.1
random: device unblocked.
VFS: mounting devfs at /dev
VFS: mounting procfs at /proc
program zpool.so returned 1
BSD shrinker: event handler list found: 0xffffa0000193f500
        BSD shrinker found: 1
BSD shrinker: unlocked, running
[I/42 dhcp]: Broadcasting DHCPDISCOVER message with xid: [981029426]
[I/244 dhcp]: Received DHCPOFFER message from DHCP server: 192.168.122.1
regarding offerred IP address: 192.168.122.1
[I/244 dhcp]: Broadcasting DHCPREQUEST message with xid: [981029426] to
SELECT offered IP: 192.168.122.15
[I/244 dhcp]: Received DHCPACK message from DHCP server: 192.168.122.1
regarding offerred IP address: 192.168.122.15
[I/244 dhcp]: Server acknowledged IP 192.168.122.15 for interface eth0 with
time to lease in seconds: 86400
eth0: 192.168.122.15
[I/244 dhcp]: Configuring eth0: ip 192.168.122.15 subnet mask 255.255.255.0
gateway 192.168.122.1 MTU 1500
[I/42 dhcp]: Waiting for IP...
ash: can't access tty; job control turned off
/ # help
Built-in commands:
------------------
        . : [ [[ alias bg break cd chdir command continue echo eval exec
        exit export false fg getopts hash help history jobs kill let
        local printf pwd read readonly return set shift source test times
        trap true type ulimit umask unalias unset wait
/ #
/ # exit
[I/0 dhcp]: Unicasting DHCPRELEASE message with xid: [2143962395] from
client: 192.168.122.15 to server: 192.168.122.1
VFS: unmounting /dev
VFS: unmounting /proc
VFS: unmounting /
main-loop: WARNING: I/O thread spun for 1000 iterations
Powering off.


Kind Regards,

Geraldo Netto
Sapere Aude => Non dvcor, dvco
http://exdev.sf.net/

On 19 February 2018 at 11:41, Nadav Har'El <n...@scylladb.com> wrote:

>
> On Mon, Feb 19, 2018 at 5:08 AM, Geraldo Netto <geraldone...@gmail.com>
> wrote:
>
>> Hello Guys,
>>
>> Just to report, it seems our current version of musl does not have some
>> glibc extensions
>> Checking their mailing lists (http://www.openwall.com/lists
>> /musl/2015/06/17/1)
>> They have implemented it later, I'll try to copy it from a newer version
>> and if it works as expected, prepare the patches
>>
>
> Sure, I already added quite a few of these __*_chk functions, in
> libc/stdio/__vfprintf_chk.c
> but __vprintf_chk.c is indeed missing there. Could you add it there?
>
> You can find the signature of this function here
> http://refspecs.linux-foundation.org/LSB_4.1.0/LSB-
> Core-generic/LSB-Core-generic/libc---vprintf-chk-1.html
>
> (you can also see what Musl did, I guess, althoug I prefer you just add
> the tiny piece of code in the existing __vfprintf_chk.c rather than add
> another source file. I don't know what Musl did for these functions, do
> they give any sort of protection or just a silly do-nothing wrapper like I
> did?).
>
>
>
>> Also, do you think it's okay if, for every problem (even the smaller ones
>> like broken builds) i create an issue on github?
>>
>
> Yes, but please do try to explain the exact problem and/or thoughts for a
> solution for each issue.
>
>
>> I think it is easier to track the conversation on github issues than on
>> mailing list
>>
>
> I agree.
>
> Nadav.
>

-- 
You received this message because you are subscribed to the Google Groups "OSv 
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to osv-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to