On Thu, Oct 25, 2018 at 4:42 AM Jose Mathew Manimala <[email protected]> wrote:
> - Update setup.py to support Centos 7.4 and 7.5 > - Override Fedora base class install param removing allowerasing > Signed-off-by: Jose Mathew Manimala <[email protected]> > --- > scripts/setup.py | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/scripts/setup.py b/scripts/setup.py > index 2cf0165..ace78a7 100755 > --- a/scripts/setup.py > +++ b/scripts/setup.py > @@ -135,6 +135,7 @@ class Fedora(object): > > class RHELbased(Fedora): > name = ['Scientific Linux', 'NauLinux', 'CentOS Linux', 'Red Hat > Enterprise Linux', 'Oracle Linux'] > + install = 'yum -y install ' > I added the "allowerasing" yum option in commit, 9cceaca880c7a4871ec4dc20cc34f63a243b6e65: setup.py: add "--allowerasing" to yum command On recent Fedora, setup.py asks to install the compact-openssl10-devel package, but if the package openssl-devel is already installed, this installation fails because of conflicts. Add the "--allowerasing" option to you to allow it to delete the conflicting package. Is it important to *not* use this option on RHEL? Or is it just cleaner not to use it unless we're sure it's needed? I have another idea. We didn't add 'compat-openssl10-devel' to all Fedora versions - just to several specific ones. So maybe only these specific versions need to have their "install" field overridden, and not the general "Fedora" object? Then you won't need to "restore" the one without allowerasing for RHEL. > class RHELbased_70(object): > packages = [] > @@ -164,7 +165,21 @@ class RHELbased(Fedora): > ec2_post_install = None > version = '7.3' > > - versions = [RHELbased_70, RHELbased_71, RHELbased_72, RHELbased_73] > + class RHELbased_74(object): > + packages = [] > + ec2_packages = [] > + test_packages = [] > + ec2_post_install = None > + version = '7.4' > + > + class RHELbased_75(object): > + packages = [] > + ec2_packages = [] > + test_packages = [] > + ec2_post_install = None > + version = '7.5' > + > + versions = [RHELbased_70, RHELbased_71, RHELbased_72, RHELbased_73, > RHELbased_74, RHELbased_75] > > class Debian(object): > name = 'debian' > -- > 1.8.3.1 > > -- > You received this message because you are subscribed to the Google Groups > "OSv Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
