On Fri, Nov 13, 2009 at 5:39 PM, Darryl L. Pierce <[email protected]> wrote:
> -            ovirt_local_boot*)
> -            local_boot=1
> +            ovirt_upgrade*)
> +            upgrade=1

I think it shouldn't hurt to keep old parameter name for compatibility reasons:
ovirt_local_boot* | ovirt_upgrade*)

otherwise it looks good, just as a follow patch please add a test case
in o-n-i autotest.sh - even upgrading to the same version would be a
good sanity check that upgrade didn't break existing configuration

_______________________________________________
Ovirt-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/ovirt-devel

Reply via email to