On Fri, Nov 13, 2009 at 10:12:17PM +0100, Alan Pevec wrote: > On Fri, Nov 13, 2009 at 5:39 PM, Darryl L. Pierce <[email protected]> wrote: > > - ovirt_local_boot*) > > - local_boot=1 > > + ovirt_upgrade*) > > + upgrade=1 > > I think it shouldn't hurt to keep old parameter name for compatibility > reasons: > ovirt_local_boot* | ovirt_upgrade*) > > otherwise it looks good, just as a follow patch please add a test case > in o-n-i autotest.sh - even upgrading to the same version would be a > good sanity check that upgrade didn't break existing configuration
Very good. I'll have a refactored patch out shortly. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
pgp59A6A2d68Q.pgp
Description: PGP signature
_______________________________________________ Ovirt-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/ovirt-devel
