On 21 December 2016 at 17:05, Daniele Di Proietto <[email protected]> wrote:
> 2016-12-20 13:28 GMT-08:00 Joe Stringer <[email protected]>:
>> Use OVS_WAIT_UNTIL() with netstat to ensure servers are listening before
>> sending requests to them. This allows us to drop --retry-connrefused on
>> wget, needed before we can switch to curl.
>
> This commit doesn't actually remove --retry-connrefused.  Should we
> remove --retry-connrefused or should we update the commit message
> (maybe I misunderstood)?  Also, the last patch introduces --retry 2 in
> CURL_OPT, so I'm assuming we should keep --retry-connrefused.

Ah, let me drop that from the commit message. This helps with that,
but the subsequent patch that updates that is missing from this series
;) (I've got it in a queue somewhere but I'd rather get these
refactoring patches in first)

>>
>> Signed-off-by: Joe Stringer <[email protected]>
>
> Thanks for doing that, it's a nice improvement!
>
> Acked-by: Daniele Di Proietto <[email protected]>

Thanks for the review.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to