On 21 December 2016 at 17:05, Daniele Di Proietto <diproiet...@ovn.org> wrote: > 2016-12-20 13:28 GMT-08:00 Joe Stringer <j...@ovn.org>: >> All of the commands starting L7 servers duplicate detailed specifics >> which inhibits readability, and makes it difficult to ensure that the >> servers are ready before the test proceeds. Add a new macro that >> provides simpler semantics from the test perspective and hide the >> details in the macro. A followup patch will extend this macro to ensure >> that servers are ready to serve requests before the test proceeds. >> >> Signed-off-by: Joe Stringer <j...@ovn.org> > > Makes sense, thanks. > > There are still a couple NETNS_DAEMONIZE in system-ovn.at that could > be replaced.
I'll do another scan across the tests for any other instances before committing. > One more comment below. > > Acked-by: Daniele Di Proietto <diproiet...@vmware.com> > >> --- >> tests/system-common-macros.at | 11 ++++ >> tests/system-ovn.at | 6 +-- >> tests/system-traffic.at | 121 >> +++++++++++++++++++++++------------------- >> 3 files changed, 79 insertions(+), 59 deletions(-) >> >> diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at >> index d41de2366695..eb5478d38d1b 100644 >> --- a/tests/system-common-macros.at >> +++ b/tests/system-common-macros.at >> @@ -230,6 +230,17 @@ m4_define([NETNS_DAEMONIZE], >> m4_define([OVS_CHECK_FIREWALL], >> [AT_SKIP_IF([systemctl status firewalld 2>&1 | grep running > >> /dev/null])]) >> >> +# OVS_START_L7([namespace], [protocol]) >> +# >> +# Start a server serving 'protocol' within 'namespace'. The server will exit >> +# when the test finishes. >> +# >> +m4_define([OVS_START_L7], >> + [PIDFILE=$(mktemp $2XXX.log) > > Should this be .pid? Yes, yes it should ;) _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
