On Thu, Dec 22, 2016 at 9:21 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Dec 20, 2016 at 01:47:16AM -0800, Andy Zhou wrote: > > From: andy zhou <az...@ovn.org> > > > > When generating conditional monitoring update request, current code > > failed to update idl's 'request-id'. This bug causes the reply > > message of the update request, regardless an ACK or a NACK, be > > logged as an unexpected message at the debug level and ignored by > > the core idl logic. > > > > In addition, the idl should not generate another conditional > > monitoring update request when there is an outstanding request. > > So that the requests and their reply are properly serialized. > > > > When the conditional monitoring is nacked by the server, drop idl > > into a client visible error state. > > > > Signed-off-by: Andy Zhou <az...@ovn.org> > > When the condition is changed when an update request is already in > flight, and the update request completes, will the code properly send > a new condition change at that point? >
When an ack is received, the request_id will be freed and set to NULL, thus unblocking ovsdb_idl_send_cond_changge() to send out the next condition change. Am I still missing something? _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
