On Wed, Jan 4, 2017 at 4:00 PM, Ben Pfaff <b...@ovn.org> wrote:
> On Tue, Dec 20, 2016 at 01:47:17AM -0800, Andy Zhou wrote:
> > To allow client to know when the conditional monitoring changes
> > has been accepted by the OVSDB server and the 'idl' contents has
> > been updated to match the new conditions.
> >
> > Signed-off-by: Andy Zhou <az...@ovn.org>
>
> The API seems a little suboptimal, in that:
> uint64_t seqno = ovsdb_idl_set_condition(idl, tc, &cond);
> uint64_t seqno2 = ovsdb_idl_set_condition(idl, tc, &cond);
> if (seqno2 == UINT_MAX) {
> ovs_fatal(0, "condition unchanged");
> }
> will always abort with "condition unchanged", I think.
>
> Is there a simple solution?
>
I did not think of this calling sequence. Thanks for the review.
How about simply return current seqno in case 'ovsdb_idl_set_condition()
does not
change current condition? I have sent out a v2 that implements this
change.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
