nickcooper-zhangtonghao <n...@opencloud.tech> writes: > hi Daniele, > I reviewed this patch. One question to ask: should we check the > hugepage mm before calling the rte_eal_init()? improvement on next version?
Are you concerned for the possible rte_panic() call which could happen if the hugepage configuration is not set correctly? > Thanks. > Nick > >> On Jan 9, 2017, at 11:21 AM, Daniele Di Proietto >> <diproiet...@vmware.com> wrote: >> >> With this commit, we allow the user to set other_config:dpdk-init=true >> after the process is started. This makes it easier to start Open >> vSwitch with DPDK using standard init scripts without restarting the >> service. >> >> This is still far from ideal, because initializing DPDK might still >> abort the process (e.g. if there not enough memory), so the user must >> check the status of the process after setting dpdk-init to true. >> >> Nonetheless, I think this is an improvement, because it doesn't require >> restarting the whole unit. >> >> CC: Aaron Conole <acon...@redhat.com <mailto:acon...@redhat.com>> >> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com >> <mailto:diproiet...@vmware.com>> >> --- >> v1->v2: No change, first non-RFC post. >> --- >> lib/dpdk-stub.c | 8 ++++---- >> lib/dpdk.c | 30 ++++++++++++++++++++---------- >> tests/ofproto-macros.at <http://ofproto-macros.at/> | 2 +- >> 3 files changed, 25 insertions(+), 15 deletions(-) > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
