On 09/01/2017 03:49, "nickcooper-zhangtonghao" <[email protected]> wrote:
>
>
>
>hi Daniele,
>I reviewed this patch. One question to ask: should we check the
>hugepage mm before calling the rte_eal_init()? improvement on next version?
How do you suggest to check for hugepage before calling rte_eal_init()?
I think everybody agrees that in the long term we need to avoid aborting if the
initialization fails, but most of that work need to happen in dpdk library.
If there's a simple check we could do here, I'm fine with including that, if
it's something more complicated and needs to be a separate patch, we should
probably defer it, since we're on feature freeze now.
Thanks,
Daniele
>
>
>
>Thanks.
>Nick
>
>
>
>On Jan 9, 2017, at 11:21 AM, Daniele Di Proietto <[email protected]>
>wrote:
>
>With
> this commit, we allow the user to set other_config:dpdk-init=true
>after
> the process is started. This makes it easier to start Open
>vSwitch
> with DPDK using standard init scripts without restarting the
>service.
>
>This
> is still far from ideal, because initializing DPDK might still
>abort
> the process (e.g. if there not enough memory), so the user must
>check
> the status of the process after setting dpdk-init to true.
>
>Nonetheless,
> I think this is an improvement, because it doesn't require
>restarting
> the whole unit.
>
>CC:
> Aaron Conole <[email protected]>
>Signed-off-by:
> Daniele Di Proietto <[email protected]>
>---
>v1->v2:
> No change, first non-RFC post.
>---
>lib/dpdk-stub.c
> | 8 ++++----
>lib/dpdk.c
> | 30 ++++++++++++++++++++----------
>tests/ofproto-macros.at <http://ofproto-macros.at/> |
> 2 +-
>3
> files changed, 25 insertions(+), 15 deletions(-)
>
>
>
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
