Joe, I investigated all the patches which changed include/linux/if_vlan.h for 802.1ad in net-next again, I found ovs compat mode doesn't need most of them at all, datapath/linux/compat/include/linux/ only includes part of changes which aren't in local $KSRC/include/linux/ but required in datapath/linux/compat/*.c, so my conclusion is we needn't them at all, https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328492.html is enough for 802.1ad backport for ovs.
-----Original Message----- From: Joe Stringer [mailto:[email protected]] Sent: Wednesday, February 8, 2017 6:31 AM To: Yang, Yi Y <[email protected]> Cc: ovs dev <[email protected]>; Yi-Hung Wei <[email protected]> Subject: Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs On 7 February 2017 at 09:44, Joe Stringer <[email protected]> wrote: > On 6 February 2017 at 16:46, Yang, Yi Y <[email protected]> wrote: >> Joe, I checked current ovs and net-next kernel, obviously some patches from >> net-next are selectively backported to ovs, but others are not, I'm not sure >> what the policy is for a new patch. It will be better that the person who >> did the patch backports it to ovs at the same time, but nobody did so. > > That's supposed to be the policy; However, depending on the patch > sometimes openvswitch isn't even the main target of the change, so the > contributor may not be aware they should do so. There may be added > difficulty if the previous contributor didn't do their backport. I > think that lately there hasn't been particularly close co-ordination > between the trees, but ideally I think that as we approach an OVS > release, we would try to sync them up. > >> My 802.1ad backport has included all the things l3 patch set depends >> on, so I think you can give it a go :-) > > Kicking off a build on my local tester, I can at least report back on > that. I see you've tested on a few platforms as well, that's great. Reporting back, I suspect that some of the older kernels don't treat the double-tagged vlans right with this series? I was using an Ubuntu trusty VM with kernel 3.13.0-92-generic plus this backport and it seems to be consistently failing this test: 4: datapath - ping between two ports on cvlan FAILED (system-traffic.at:88) The test output just shows that a ping tries about 10 times and fails all of the times. I didn't investigate further. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
