Joe, thank you for explanation, let us push 802.1ad backport patches first, 
Eric Garver has acked two of them, I'll rework another one patch he commented. 
What Valentine mentioned has no business with 802.1 ad, it is what we want to 
consider after Eric Garver's rtnetlink userspace patches are merged, we have no 
way to use in-kernel data path to do it without rtnetlink userspace patches.

Can you point out which patches  for 802.1ad are missing? I almost checked all 
the 802.1 ad patches, ovs doesn't use most of them, most of them make nonsense 
to ovs. Eric, please help point out if I missed something.

-----Original Message-----
From: Joe Stringer [mailto:[email protected]] 
Sent: Friday, February 10, 2017 8:01 AM
To: Yang, Yi Y <[email protected]>
Cc: ovs dev <[email protected]>; Yi-Hung Wei <[email protected]>
Subject: Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

On 8 February 2017 at 18:50, Yang, Yi Y <[email protected]> wrote:
> Then, are you merging 
> https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328492.html or 
> do I need to do anything else for it?

It looks like the backport breaks the existing kernel module tests on older 
kernels, without even using the new functionality. I've provided feedback on 
how you might further dig into that, and I don't believe I've seen confirmation 
that you observe the same thing, or any proposed solutions.

I've mentioned previously a preference to see patches backported in the 
canonical order. I believe there's just a few patches missing from before 
802.1ad, and discussions are ongoing to address those backports. I expect with 
time, those will be proposed and merged, and then we can look at 802.1ad.

Finally, patches always need review before merging. Given that others in the 
community have previously looked into 802.1ad, I was looking to see that people 
with more detailed knowledge of these codepaths would take a first look. I see 
that Eric has now done so, and there is feedback to address. I also see that 
Valentine has provided some feedback.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to