Thanks for the fix. Acked-by: Nithin Raju <[email protected]>
________________________________________ From: [email protected] <[email protected]> on behalf of Alin Serdean <[email protected]> Sent: Friday, February 17, 2017 3:10 AM To: [email protected] Subject: [ovs-dev] [PATCH] windows: Broken internal netdevs Commit fa07525f9cf3fa698ebc23ea09da477d3d881a87 fixed error logging for for regular netdevs, however it overlooked "internal" netdevs. This patch allows "internal" netdev objects to be created and passed to dpif_port_add(). Reported-by: Nithin Raju <[email protected]> Signed-off-by: Alin Gabriel Serdean <[email protected]> --- Intended for branch-2.5,branch-2.6,branch-2.7,master --- lib/netdev-windows.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c index b22bd09..375cb32 100644 --- a/lib/netdev-windows.c +++ b/lib/netdev-windows.c @@ -159,7 +159,10 @@ netdev_windows_system_construct(struct netdev *netdev_) /* Query the attributes and runtime status of the netdev. */ ret = query_netdev(netdev_get_name(&netdev->up), &info, &buf); - if (ret) { + /* "Internal" netdevs do not exist in the kernel yet. They need to be + * transformed into a netdev object and passed to dpif_port_add(), which + * will add them to the kernel. */ + if (strcmp(netdev_get_type(&netdev->up), "internal") && ret) { return ret; } ofpbuf_delete(buf); -- 2.10.2.windows.1 _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=-xl6DPE_Y3uQD-mpZD7osBo2iL4s3jwdmSjTlGgjlsQ&m=P92jgkw_e8yXcobASp3agdOOn_TbmMcTLXwVjH037sY&s=z1OeB_nNoNtLKaQeFUZ-JfP_-aZiU4CmjF5VVblMHuc&e= _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
