On 17 February 2017 at 03:10, Alin Serdean <[email protected]> wrote:
> Commit fa07525f9cf3fa698ebc23ea09da477d3d881a87 fixed error logging for > for regular netdevs, however it overlooked "internal" netdevs. > > This patch allows "internal" netdev objects to be created and passed to > dpif_port_add(). > > Reported-by: Nithin Raju <[email protected]> > Signed-off-by: Alin Gabriel Serdean <[email protected]> > --- > Intended for branch-2.5,branch-2.6,branch-2.7,master > Thanks, applied to all the above branches. > --- > lib/netdev-windows.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c > index b22bd09..375cb32 100644 > --- a/lib/netdev-windows.c > +++ b/lib/netdev-windows.c > @@ -159,7 +159,10 @@ netdev_windows_system_construct(struct netdev > *netdev_) > > /* Query the attributes and runtime status of the netdev. */ > ret = query_netdev(netdev_get_name(&netdev->up), &info, &buf); > - if (ret) { > + /* "Internal" netdevs do not exist in the kernel yet. They need to be > + * transformed into a netdev object and passed to dpif_port_add(), > which > + * will add them to the kernel. */ > + if (strcmp(netdev_get_type(&netdev->up), "internal") && ret) { > return ret; > } > ofpbuf_delete(buf); > -- > 2.10.2.windows.1 > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
