Deleted groups hang around in the group table until the next grace period,
so it's important for the group stats code to pretend that they're gone
until they really get deleted.

Reported-by: "Timothy M. Redaelli" <[email protected]>
Reported-at: 
https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331117.html
Signed-off-by: Ben Pfaff <[email protected]>
---
 ofproto/ofproto.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 7440d5b52092..4d3d46c8ba45 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -6641,7 +6641,10 @@ handle_group_request(struct ofconn *ofconn,
     ovs_mutex_lock(&ofproto_mutex);
     if (group_id == OFPG_ALL) {
         CMAP_FOR_EACH (group, cmap_node, &ofproto->groups) {
-            cb(group, &replies);
+            if (versions_visible_in_version(&group->versions,
+                                            OVS_VERSION_MAX)) {
+                cb(group, &replies);
+            }
         }
     } else {
         group = ofproto_group_lookup__(ofproto, group_id, OVS_VERSION_MAX);
-- 
2.10.2

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to