On Mon, Apr 24, 2017 at 04:37:51PM -0400, Leif Madsen wrote:
> On Mon, Apr 24, 2017 at 3:57 PM, Ben Pfaff <[email protected]> wrote:
>
> > On Mon, Apr 24, 2017 at 03:52:53PM -0400, Leif Madsen wrote:
> > > I think this change might have broken packaging :)
> > >
> > > I just tested, and with the removal / renaming of the man8 pages for
> > > ovs-test and ovs-vlan-test, the RPM fails to build because of missing
> > files
> > > that no longer match the glob.
> > >
> > > These two lines need to be removed from the build:
> > >
> > > 471 %{_mandir}/man8/ovs-test.8*
> > > 472 %{_mandir}/man8/ovs-vlan-test.8*
> > >
> > >
> > > I'll submit a patch shortly.
> >
> > OK, I'm confused then. There was no removal or renaming of the
> > installed man8 pages, only of the source files. So, when I run "make
> > install DESTDIR=$PWD/inst", I get a file
> > inst/usr/share/man/man8/ovs-test.8 installed, and that should be the
> > same as before.
> >
> > Any idea what's going on?
> >
>
> Huh, well then I'm very confused as well :)
>
> I just did a test, and things seem to build fine when I remove those two
> lines. Otherwise, the RPM will fail to build with the following:
>
> Processing files:
> openvswitch-test-2.7.90.14191.git3570f7e4-1.el7.centos.noarch
> error: File not found by glob:
> /builddir/build/BUILDROOT/openvswitch-2.7.90.14191.git3570f7e4-1.el7.centos.x86_64/usr/share/man/man8/ovs-test.8*
> error: File not found by glob:
> /builddir/build/BUILDROOT/openvswitch-2.7.90.14191.git3570f7e4-1.el7.centos.x86_64/usr/share/man/man8/ovs-vlan-test.8*
>
>
> RPM build errors:
> File not found by glob:
> /builddir/build/BUILDROOT/openvswitch-2.7.90.14191.git3570f7e4-1.el7.centos.x86_64/usr/share/man/man8/ovs-test.8*
> File not found by glob:
> /builddir/build/BUILDROOT/openvswitch-2.7.90.14191.git3570f7e4-1.el7.centos.x86_64/usr/share/man/man8/ovs-vlan-test.8*
>
>
>
> So I'm not entirely sure why my build isn't resulting in those files. I
> have everything being built from a script and done in mock, so things
> should be quite reproducable. I see the same failure both on my COPR repo,
> and in my local build environment.
I don't really have a RPM build environment (my main distro is Debian),
but can I suggest an experiment? Something like this:
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index dbcab00cd428..1d43ebe50a69 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -228,6 +228,7 @@ make -f %{_datadir}/selinux/devel/Makefile
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
+find $RPM_BUILD_ROOT -name 'ovs-test*'
install -d -m 0755 $RPM_BUILD_ROOT%{_sysconfdir}/openvswitch
to find out whether the ovs-test manpage is being installed at all and
if so where.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
