> From: "Stephen Finucane" <[email protected]> > To: "Lance Richardson" <[email protected]>, "Ben Pfaff" <[email protected]> > Cc: "ovs dev" <[email protected]> > Sent: Wednesday, 26 April, 2017 11:00:55 AM > Subject: Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST > > On Wed, 2017-04-26 at 10:55 -0400, Lance Richardson wrote: > > > From: "Ben Pfaff" <[email protected]> > > > To: "Lance Richardson" <[email protected]> > > > Cc: "Leif Madsen" <[email protected]>, "ovs dev" <dev@openvswitch. > > > org> > > > Sent: Wednesday, 26 April, 2017 10:33:09 AM > > > Subject: Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST > > > > > > On Tue, Apr 25, 2017 at 04:03:55PM -0400, Lance Richardson wrote: > > > > I ran into this a little while ago. The problem in my case was > > > > that > > > > sphinx-build > > > > was not installed, so these man pages were not being built (seems > > > > odd that > > > > this > > > > would not cause a build failure...) > > > > > > > > Doing "yum install python-sphinx" let me build the rpms > > > > successfully once > > > > again. Seems we should add "BuildRequires: python-sphinx" to the > > > > spec file. > > > > > > Huh. Somehow I thought that we'd made Sphinx an overall build > > > requirement. Maybe that's the right thing to do. > > > > > > > The rules to build rst-formatted man pages in the top-level > > Makefile.in are predicated on HAVE_SPHINX_TRUE, which does give the > > impression that Sphinx is optional. > > > > Lance > > Yup, it's optional since these were only used for HTML docs initially. > I didn't change that as HAVE_GROFF is also a thing, afaict, and I > wasn't sure if man pages were essential. Maybe they should be now. >
It seems fine to me to handle this by having stricter requirements for packaging than for the base build (as they need to be anyway). OTOH there would be some benefits to making it a requirement for the base build, such as catching build errors earlier. Lance > Stephen > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
