On Mon, May 08, 2017 at 09:22:42AM +0000, Weglicki, MichalX wrote: > > -----Original Message----- > > From: Ben Pfaff [mailto:[email protected]] > > Sent: Monday, May 1, 2017 7:36 PM > > To: Weglicki, MichalX <[email protected]> > > Cc: [email protected] > > Subject: Re: [ovs-dev] [PATCH v2] ofproto-dpif-ipfix: total counters. > > > > On Thu, Apr 20, 2017 at 03:25:13PM +0100, mweglicx wrote: > > > Implementation of IPFix counters which hold > > > total values measured since metering process startup. > > > > > > v2: Patch is reapplied for a review because > > > it hasn't been correctly marked in patchwork. > > > > > > Signed-off-by: Michal Weglicki <[email protected]> > > > > Thanks a lot for working on IPFix! I don't have IPFix expertise, and I > > don't think the other OVS committers have much either, so I need to ask > > some dumb questions to better understand the implications of this patch. > > > > Actually, maybe I just need to ask one. This changes the wire format of > > the IPFix reports that go out. Will this require changes to IPFix > > collectors that understood the previous format, that is, is the new > > format backward compatible with collectors that expected the previous > > format? I understand that IPFix uses a template format to tell > > collectors the format of what it's sending, but it's not clear to me > > whether or not that prevents this kind of compatibility issue. > > > > Thanks, > > > > Ben. > > Hello Ben, > > So counters which just got exposed through my patch are part of RFC > which is already partially implemented in OVS. I've just added few > missing ones, and I'm going to implement also others from same > category (https://tools.ietf.org/html/rfc5102#section-5.10) > > However to answer your question directly those counters are > part of standard group of IPFix counters, so no changes on > Collector side are required. IPFix sends counters in kind of > dictionary format, so adding any counter shouldn't break > backward compatibility - IPFix even defines something like > enterprise counters (vendor specific) where any agent can > define own counters in the template and send those over > (not every collector supports it, but data-wise it shouldn't > break anything on collector side). > > My patch was also tested against libipfix/ipfix_collector > and no additional changes were required to see new > counters on collector side.
Thanks for the reassurance! I'll take a closer look at the patch now. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
