On 20 May 2017 at 11:09, Darrell Ball <[email protected]> wrote: > The checks to populate ct_orig_tuple in miniflow_extract > includes recirc_id being non-zero. This is changed here > to populate the ct_orig_tuple fields based only on ct_state > per the logic of the design. > > Signed-off-by: Darrell Ball <[email protected]>
I'm not exactly sure what "per the logic of the design" is supposed to mean, and I suspect that someone reading through the git logs would be just as lost. As far as I'm aware, any patch to OVS should be "per the logic of the design", right? Do you mean "The ct_orig_tuple fields are designed to be read only if the ct_state is valid, so do not populate that field if the packet has not gone through the connection tracker"? I think that this kind of description would provide at least a little extra context to help understand the motivation behind the change. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
