Hi Guru, No, I didn’t run unit tests before. But I have verified manually, that ovsdb-server and ovs-vswitchd daemons starts normally when run as a service/console application.
I have run the unit tests now, so far 1812 tests have executed and I didn’t see any issues. But the test suite got hung at “1813: SSL db: implementation”, so running it again. Thanks, Anand Kumar From: Guru Shetty <[email protected]> Date: Friday, June 16, 2017 at 11:06 AM To: Anand Kumar <[email protected]> Cc: ovs dev <[email protected]> Subject: Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from service_start function On 16 June 2017 at 10:06, Anand Kumar <[email protected]<mailto:[email protected]>> wrote: When --syslog-method is passed as a cmd line argument and ovs daemons are started as a service, --syslog-method argument is not honoured, as vlog module is initialized by service_start function before parsing the command line arguments. Easy way to fix this, is to remove vlog_init() from the service start function and let the first log message to initialize the vlog module. Signed-off-by: Anand Kumar <[email protected]<mailto:[email protected]>> Did you run the unit tests after this change? --- lib/daemon-windows.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c index 5804284..1ba714d 100644 --- a/lib/daemon-windows.c +++ b/lib/daemon-windows.c @@ -138,13 +138,6 @@ service_start(int *argcp, char **argvp[]) *argcp = sargc; *argvp = *sargvp; - /* XXX: Windows implementation cannot have a unixctl commands in the - * traditional sense of unix domain sockets. If an implementation is - * done that involves 'unixctl' vlog commands the following call is - * needed to make sure that the unixctl commands for vlog get - * registered in a daemon, even before the first log message. */ - vlog_init(); - return; } -- 2.9.3.windows.1 _______________________________________________ dev mailing list [email protected]<mailto:[email protected]> https://mail.openvswitch.org/mailman/listinfo/ovs-dev<https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=p_f30AHvC_ptaYSCwAmqgshIkP0PTspGlSuqqv8dUgA&s=Bgb5zvy7WnySj3t9Be-fai1RATcwJiGGEcsc4dPxK30&e=> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
