Alin,

Thanks for looking into this!

Acked-by: Sairam Venugopal <[email protected]>





On 6/20/17, 12:14 PM, "[email protected] on behalf of Alin 
Serdean" <[email protected] on behalf of 
[email protected]> wrote:

>Unit tests are passing.
>
>
>
>I also gave it a test via the installer.
>
>
>
>Acked-by: Alin Gabriel Serdean <[email protected]>
>
>
>
>
>
>> -----Original Message-----
>
>> From: [email protected] [mailto:ovs-dev-
>
>> [email protected]] On Behalf Of Anand Kumar
>
>> Sent: Saturday, June 17, 2017 1:47 AM
>
>> To: Guru Shetty <[email protected]>
>
>> Cc: ovs dev <[email protected]>
>
>> Subject: Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from
>
>> service_start function
>
>> 
>
>> Hi Guru,
>
>> 
>
>> No, I didn’t run unit tests before. But I have verified manually, that ovsdb-
>
>> server and ovs-vswitchd daemons starts normally when run as a
>
>> service/console application.
>
>> 
>
>> I have run the unit tests now, so far 1812 tests have executed and I didn’t
>
>> see any issues. But the test suite got hung at “1813: SSL db: 
>> implementation”,
>
>> so running it again.
>
>> 
>
>> Thanks,
>
>> Anand Kumar
>
>> 
>
>> From: Guru Shetty <[email protected]>
>
>> Date: Friday, June 16, 2017 at 11:06 AM
>
>> To: Anand Kumar <[email protected]>
>
>> Cc: ovs dev <[email protected]>
>
>> Subject: Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from
>
>> service_start function
>
>> 
>
>> 
>
>> 
>
>> On 16 June 2017 at 10:06, Anand Kumar
>
>> <[email protected]<mailto:[email protected]>> wrote:
>
>> When --syslog-method is passed as a cmd line argument and ovs daemons
>
>> are started as a service, --syslog-method argument is not honoured, as vlog
>
>> module is initialized by service_start function before parsing the command
>
>> line arguments.
>
>> 
>
>> Easy way to fix this, is to remove vlog_init() from the service start 
>> function
>
>> and let the first log message to initialize the vlog module.
>
>> 
>
>> Signed-off-by: Anand Kumar
>
>> <[email protected]<mailto:[email protected]>>
>
>
>
>_______________________________________________
>dev mailing list
>[email protected]
>https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=6PSoRMb2_Za8AiSS_bUShxGINRprA-Pjd8OWtXSFNC0&s=F7JVaof-epz2VayD_XtQ5jsyf3SNYodbNoiAw2ZTMbg&e=
> 
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to