On Mon, Jun 19, 2017 at 10:26:56AM +0000, Zoltán Balogh wrote:
> >
> > A new concern came up while thinking about this series. The
> > OVS_ATTR_PACKET_TYPE does not appear to be implemented in the kernel
> > module, and what's more, because of #ifdefs, OVS_ATTR_PACKET_TYPE will
> > actually have a different value in the kernel module than in userspace.
> > What's the plan here?
>
> Hi Ben,
>
> OVS_KEY_ATTR_PACKET_TYPE is represented with OVS_KEY_ATTR_ETHERNET and
> OVS_KEY_ATTR_ETHERTYPE in the kernel.
> From Google doc:
> "The presence of netlink key attribute OVS_KEY_ATTR_ETHERNET is used to
> indicate if it's about L2 or L3 packet on the netlink interface. The "L3"
> packet type is encoded in the OVS_KEY_ATTR_ETHERTYPE netlink attribute."
Oh, OK. The header file is confusing. I think that
OVS_KEY_ATTR_PACKET_TYPE should be inside #ifndef __KERNEL__, to
clarify. I sent a patch:
https://patchwork.ozlabs.org/patch/778029/
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
