On Mon, May 18, 2026 at 10:38 AM Eelco Chaudron <[email protected]> wrote:
>
>
> On 18 May 2026, at 16:36, Eelco Chaudron wrote:
>
> > On 5 May 2026, at 17:59, Mike Pattrick via dev wrote:
> >
> >> Previously read_cert_file() only checked for EOF as returned by getc
> >> when reading a cert file. This patch checks for ferror and feof before
> >> continuing to loop over file contents.
>>
> >> Found with clang analyze.
> >>
> >> Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.")
> >> Signed-off-by: Mike Pattrick <[email protected]>
> >
> > Thanks for taking my suggestion, but your commit message needs some
> updating.
>
> I guess if you just reply here with a suggestion, I can change it
> when applying. The rest seems fine, so there is no need to respin
> the whole series for this.
stream-ssl: Check for EOF in read_cert_file() loop.
Previously read_cert_file() only escaped from its getc loop with a call
to isspace. Clang identified this as undefined behavior. This patch adds
an explicit check for EOF in the getc loop.
Found with clang analyze.
Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.")
Signed-off-by: Mike Pattrick <[email protected]>
>
> > //Eelco
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
