Re: [ovs-dev] [PATCH v2 1/6] classifier: Avoid undefined behavior on 32-bit shift in raw_get_prefix().

[Eelco Chaudron via dev]

On 5 May 2026, at 17:59, Mike Pattrick via dev wrote:

> Shifting a 32-bit value by 32 bits is undefined behavior in C.  This patch
> adds a check in raw_get_prefix for when ofs == 0, which would cause such
> a bitshift, and returns early from that function.
>
> Found with clang analyze.
>
> Fixes: 13751fd88c4b ("Classifier: Track address prefixes.")

Once again thanks for the series Mike. I applied it, with two small
modifications: the subject of this first commit (so it will fit the
recommended length), and the commit message of patch 5 as discussed
earlier.

Cheers,

Eelco

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev