________________________________________
From: [email protected] <[email protected]> on
behalf of Alin Serdean <[email protected]>
Sent: Thursday, July 13, 2017 9:40 PM
To: [email protected]
Subject: [ovs-dev] [PATCH 09/40] datapath-windows: Fix possible NULL
dereference in BufferMgmt
The mdl can be NULL.
Found using WDK 10 static code analysis.
Signed-off-by: Alin Gabriel Serdean <[email protected]>
---
datapath-windows/ovsext/BufferMgmt.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/BufferMgmt.c
b/datapath-windows/ovsext/BufferMgmt.c
index 6354781..53490fa 100644
--- a/datapath-windows/ovsext/BufferMgmt.c
+++ b/datapath-windows/ovsext/BufferMgmt.c
@@ -1674,9 +1674,11 @@ OvsCompleteNBL(POVS_SWITCH_CONTEXT context,
PNET_BUFFER nbTemp = NET_BUFFER_LIST_FIRST_NB(nbl);
while (nbTemp) {
PMDL mdl = NET_BUFFER_FIRST_MDL(nbTemp);
+ if (mdl) {
+ ASSERT(mdl->Next == NULL);
+ OvsFreeMDLAndData(mdl);
+ }
NET_BUFFER_FIRST_MDL(nbTemp) = NULL;
- ASSERT(mdl->Next == NULL);
- OvsFreeMDLAndData(mdl);
nbTemp = NET_BUFFER_NEXT_NB(nbTemp);
}
}
--
2.10.2.windows.1
_______________________________________________
Acked-by: Shashank Ram <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
